New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13] Use S3Client::upload instead of splitting single/multipart upload ourselves #8102

Merged
merged 1 commit into from Feb 8, 2018

Conversation

Projects
None yet
3 participants
@icewind1991
Member

icewind1991 commented Jan 29, 2018

Backport of #8033

Use S3Client::upload instead of splitting single/multipart upload our…
…selves

Signed-off-by: Robin Appelman <robin@icewind.nl>

@icewind1991 icewind1991 added this to the Nextcloud 13.0.1 milestone Jan 29, 2018

@icewind1991 icewind1991 requested review from rullzer and MorrisJobke Jan 29, 2018

@codecov

This comment has been minimized.

codecov bot commented Jan 29, 2018

Codecov Report

Merging #8102 into stable13 will increase coverage by <.01%.
The diff coverage is 100%.

@@              Coverage Diff               @@
##             stable13    #8102      +/-   ##
==============================================
+ Coverage       51.23%   51.23%   +<.01%     
+ Complexity      24981    24973       -8     
==============================================
  Files            1607     1607              
  Lines           95049    95020      -29     
  Branches         1376     1376              
==============================================
- Hits            48695    48684      -11     
+ Misses          46354    46336      -18
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/ObjectStore/S3ObjectTrait.php 75% <100%> (+17.1%) 5 <0> (-8) ⬇️
lib/private/Security/CertificateManager.php 91.08% <0%> (-1%) 39% <0%> (ø)
lib/private/Server.php 81.55% <0%> (+0.11%) 134% <0%> (ø) ⬇️
lib/private/Files/Cache/Propagator.php 96.2% <0%> (+1.26%) 16% <0%> (ø) ⬇️
@rullzer

🐘

@MorrisJobke MorrisJobke merged commit 197c97e into stable13 Feb 8, 2018

3 checks passed

codecov/patch 100% of diff hit (target 51.23%)
Details
codecov/project 51.23% (+<.01%) compared to 7b227d8
Details
continuous-integration/drone/pr the build was successful
Details

@MorrisJobke MorrisJobke deleted the s3-uploader-13 branch Feb 8, 2018

@MorrisJobke MorrisJobke referenced this pull request Mar 9, 2018

Merged

13.0.1 RC1 #8748

10 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment