New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable12] Update CRL because user_sql cert was lost #8152

Merged
merged 1 commit into from Feb 2, 2018

Conversation

Projects
None yet
3 participants
@MorrisJobke
Member

MorrisJobke commented Feb 2, 2018

Update CRL because user_sql cert was lost
* see nextcloud/app-certificate-requests#129

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@nickvergessen

This comment has been minimized.

Member

nickvergessen commented Feb 2, 2018

The diff here is different, was it forgotten last time?

@MorrisJobke

This comment has been minimized.

Member

MorrisJobke commented Feb 2, 2018

The diff here is different, was it forgotten last time?

Seems like that.

@MorrisJobke MorrisJobke changed the title from Update CRL because user_sql cert was lost to [stable12] Update CRL because user_sql cert was lost Feb 2, 2018

@codecov

This comment has been minimized.

codecov bot commented Feb 2, 2018

Codecov Report

Merging #8152 into stable12 will decrease coverage by <.01%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             stable12    #8152      +/-   ##
==============================================
- Coverage       53.84%   53.83%   -0.01%     
  Complexity      22761    22761              
==============================================
  Files            1385     1385              
  Lines           87150    87150              
  Branches         1331     1331              
==============================================
- Hits            46925    46921       -4     
- Misses          40225    40229       +4
Impacted Files Coverage Δ Complexity Δ
lib/private/Security/CertificateManager.php 91.08% <0%> (-1%) 39% <0%> (ø)
core/js/js.js 61.27% <0%> (-0.56%) 0% <0%> (ø)
lib/private/Server.php 84.8% <0%> (+0.12%) 121% <0%> (ø) ⬇️
lib/private/Files/Cache/Propagator.php 96.2% <0%> (+1.26%) 16% <0%> (ø) ⬇️

@MorrisJobke MorrisJobke merged commit 02fba90 into stable12 Feb 2, 2018

2 of 3 checks passed

codecov/project 53.83% (-0.01%) compared to 26beb5b
Details
codecov/patch Coverage not affected when comparing 26beb5b...f2e83c2
Details
continuous-integration/drone/pr the build was successful
Details

@MorrisJobke MorrisJobke deleted the 12-8150 branch Feb 2, 2018

@MorrisJobke MorrisJobke referenced this pull request Mar 9, 2018

Merged

12.0.6 RC 1 #8750

2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment