New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable13] Use a phan version instead of master #8195

Merged
merged 1 commit into from Feb 6, 2018

Conversation

Projects
None yet
3 participants
@MorrisJobke
Member

MorrisJobke commented Feb 6, 2018

Backport of #8172

@rullzer

rullzer approved these changes Feb 6, 2018

@danxuliu

danxuliu requested changes Feb 6, 2018 edited

Phan 0.11.1 requires PHP 7.2, but its image version was not bumped (second commit from original pull request was not included in this one edit: well, second commit would not be valid on its own either; it would require the bump from the third one anyway to use the latest PHP 7.2 image).

@codecov

This comment has been minimized.

codecov bot commented Feb 6, 2018

Codecov Report

Merging #8195 into stable13 will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             stable13    #8195   +/-   ##
===========================================
  Coverage       51.23%   51.23%           
  Complexity      24985    24985           
===========================================
  Files            1607     1607           
  Lines           95062    95062           
  Branches         1376     1376           
===========================================
  Hits            48701    48701           
  Misses          46361    46361
@MorrisJobke

This comment has been minimized.

Member

MorrisJobke commented Feb 6, 2018

also 7.2-11 contains already a newer PHPUnit - so I used the old php 7.2-9 image ;) Let's see

@danxuliu

This comment has been minimized.

Member

danxuliu commented Feb 6, 2018

Phan needs Redis and Imagick, which were included in 7.2-11. Is the newer PHPUnit incompatible with Phan tests in stable13? In that case I guess that we will have to use Phan 0.10.x for stable13, as Phan 0.10.x is compatible with PHP 7.1.

@rullzer

This comment has been minimized.

Member

rullzer commented Feb 6, 2018

Aaah right... yeah just use the one compatible with 7.1 for 13 then i think.

@MorrisJobke

This comment has been minimized.

Member

MorrisJobke commented Feb 6, 2018

Phan needs Redis and Imagick, which were included in 7.2-11. Is the newer PHPUnit incompatible with Phan tests in stable13? In that case I guess that we will have to use Phan 0.10.x for stable13, as Phan 0.10.x is compatible with PHP 7.1.

I just wanted to keep the versions the same. Let me try with 7.2-11 and if this does not work we will use 0.10.x of phan.

Use a phan version instead of master
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@danxuliu

This comment has been minimized.

Member

danxuliu commented Feb 6, 2018

Drone is happy with 7.2-11 :-D

@MorrisJobke MorrisJobke merged commit b16824d into stable13 Feb 6, 2018

3 checks passed

codecov/patch Coverage not affected when comparing b206870...c1423ee
Details
codecov/project 51.23% remains the same compared to b206870
Details
continuous-integration/drone/pr the build was successful
Details

@MorrisJobke MorrisJobke deleted the 13-8172 branch Feb 6, 2018

@MorrisJobke MorrisJobke referenced this pull request Mar 9, 2018

Merged

13.0.1 RC1 #8748

10 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment