New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nextcloud 12 is not compatible with newer than php 7.1 #8216

Merged
merged 1 commit into from Feb 8, 2018

Conversation

Projects
None yet
3 participants
@rullzer
Member

rullzer commented Feb 7, 2018

Backport of #6830

Fixes #7415

Just to avoid users from trying this with a to new (untested) php version

  • Moved the check logic to 1 place
  • All directly callable scripts just require this on top
  • exit hard (-1) so we know scripts won't continue
  • Return status 500 so no sync clients will try fancy stuff

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

}
// Show warning if > PHP 7.1 is used as Nextcloud 12 is not compatible with > PHP 7.1
if (version_compare(PHP_VERSION, '7.2.0') !== -1) {

This comment has been minimized.

@MorrisJobke

MorrisJobke Feb 7, 2018

Member

I guess you meant '7.1.0' here 😉

This comment has been minimized.

@MorrisJobke

MorrisJobke Feb 7, 2018

Member

So this will run with 7.2.0 just fine, but error out with 7.2.1+. 🤔

This comment has been minimized.

@rullzer

rullzer Feb 7, 2018

Member

No the version has to be lower than 7.2.0. So all 7.1.x are allowed.

This comment has been minimized.

@nickvergessen

nickvergessen Feb 7, 2018

Member

Just use , '<' instead of comparing !== -1

This comment has been minimized.

@rullzer

rullzer Feb 7, 2018

Member

Fixed

@codecov

This comment has been minimized.

codecov bot commented Feb 7, 2018

Codecov Report

Merging #8216 into stable12 will increase coverage by <.01%.
The diff coverage is 0%.

@@              Coverage Diff               @@
##             stable12    #8216      +/-   ##
==============================================
+ Coverage       53.84%   53.84%   +<.01%     
  Complexity      22762    22762              
==============================================
  Files            1385     1386       +1     
  Lines           87152    87155       +3     
  Branches         1331     1331              
==============================================
+ Hits            46926    46928       +2     
- Misses          40226    40227       +1
Impacted Files Coverage Δ Complexity Δ
index.php 0% <0%> (ø) 0 <0> (ø) ⬇️
cron.php 0% <0%> (ø) 0 <0> (ø) ⬇️
ocs/v1.php 0% <0%> (ø) 0 <0> (ø) ⬇️
remote.php 0% <0%> (ø) 0 <0> (ø) ⬇️
console.php 0% <0%> (ø) 0 <0> (ø) ⬇️
status.php 0% <0%> (ø) 0 <0> (ø) ⬇️
lib/versioncheck.php 0% <0%> (ø) 0 <0> (?)
ocs/providers.php 0% <0%> (ø) 0 <0> (ø) ⬇️
public.php 0% <0%> (ø) 0 <0> (ø) ⬇️
lib/private/Server.php 84.68% <0%> (-0.13%) 121% <0%> (ø)
... and 5 more
Nextcloud 12 is not compatible with newer than php 7.1
Just to avoid users from trying this with a to new (untested) php version

* Moved the check logic to 1 place
* All directly callable scripts just require this on top
* exit hard (-1) so we know scripts won't continue
* Return status 500 so no sync clients will try fancy stuff

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

@MorrisJobke MorrisJobke merged commit 2be70b1 into stable12 Feb 8, 2018

1 check failed

continuous-integration/drone/pr the build failed
Details

@MorrisJobke MorrisJobke deleted the 6830_12 branch Feb 8, 2018

@MorrisJobke MorrisJobke referenced this pull request Mar 9, 2018

Merged

12.0.6 RC 1 #8750

2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment