New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13] keep previous exception when transforming to dav exception #8228

Merged
merged 1 commit into from Feb 7, 2018

Conversation

Projects
None yet
3 participants
@icewind1991
Member

icewind1991 commented Feb 7, 2018

Backport of #8224

keep previous exception when transforming to dav exception
Signed-off-by: Robin Appelman <robin@icewind.nl>

@icewind1991 icewind1991 added this to the Nextcloud 13.0.1 milestone Feb 7, 2018

@icewind1991 icewind1991 requested review from rullzer and nickvergessen Feb 7, 2018

@rullzer

rullzer approved these changes Feb 7, 2018

@codecov

This comment has been minimized.

codecov bot commented Feb 7, 2018

Codecov Report

Merging #8228 into stable13 will increase coverage by <.01%.
The diff coverage is 40%.

@@              Coverage Diff               @@
##             stable13    #8228      +/-   ##
==============================================
+ Coverage       51.23%   51.23%   +<.01%     
  Complexity      24990    24990              
==============================================
  Files            1608     1608              
  Lines           95106    95106              
  Branches         1376     1376              
==============================================
+ Hits            48730    48731       +1     
+ Misses          46376    46375       -1
Impacted Files Coverage Δ Complexity Δ
apps/dav/lib/Connector/Sabre/Directory.php 65.6% <0%> (ø) 65 <0> (ø) ⬇️
.../dav/lib/Connector/Sabre/Exception/InvalidPath.php 81.81% <100%> (ø) 3 <1> (ø) ⬇️
apps/files_trashbin/lib/Trashbin.php 72.53% <0%> (+0.24%) 136% <0%> (ø) ⬇️

@nickvergessen nickvergessen merged commit 36eb93d into stable13 Feb 7, 2018

2 of 3 checks passed

codecov/patch 40% of diff hit (target 51.23%)
Details
codecov/project 51.23% (+<.01%) compared to f8740a1
Details
continuous-integration/drone/pr the build was successful
Details

@nickvergessen nickvergessen deleted the dav-dir-exception-previous-13 branch Feb 7, 2018

@MorrisJobke MorrisJobke referenced this pull request Mar 9, 2018

Merged

13.0.1 RC1 #8748

10 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment