New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13] Fix deleting folders when using s3 external storage #8261

Merged
merged 2 commits into from Feb 13, 2018

Conversation

Projects
None yet
3 participants
@icewind1991
Member

icewind1991 commented Feb 8, 2018

Backport of #8100

@icewind1991 icewind1991 added this to the Nextcloud 13.0.1 milestone Feb 8, 2018

@icewind1991 icewind1991 requested review from rullzer and MorrisJobke Feb 8, 2018

@codecov

This comment has been minimized.

codecov bot commented Feb 8, 2018

Codecov Report

Merging #8261 into stable13 will decrease coverage by <.01%.
The diff coverage is 0%.

@@              Coverage Diff               @@
##             stable13    #8261      +/-   ##
==============================================
- Coverage       51.23%   51.23%   -0.01%     
- Complexity      24985    24986       +1     
==============================================
  Files            1608     1608              
  Lines           95086    95089       +3     
  Branches         1376     1376              
==============================================
  Hits            48718    48718              
- Misses          46368    46371       +3
Impacted Files Coverage Δ Complexity Δ
apps/files_external/lib/Lib/Storage/AmazonS3.php 0% <0%> (ø) 111 <0> (+1) ⬆️

icewind1991 added some commits Jan 29, 2018

adjust s3 bulk delete to new sdk syntax
Signed-off-by: Robin Appelman <robin@icewind.nl>
fix invalidating folder cache for s3
Signed-off-by: Robin Appelman <robin@icewind.nl>

@rullzer rullzer merged commit 57e3900 into stable13 Feb 13, 2018

1 of 3 checks passed

codecov/patch 0% of diff hit (target 51.23%)
Details
codecov/project 51.23% (-0.01%) compared to 4c21fc8
Details
continuous-integration/drone/pr the build was successful
Details

@rullzer rullzer deleted the s3-folder-delete-13 branch Feb 13, 2018

@MorrisJobke MorrisJobke referenced this pull request Mar 9, 2018

Merged

13.0.1 RC1 #8748

10 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment