New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12] Fix deleting folders when using s3 external storage #8262

Merged
merged 2 commits into from Feb 13, 2018

Conversation

Projects
None yet
4 participants
@icewind1991
Member

icewind1991 commented Feb 8, 2018

Backport of #8100

@icewind1991 icewind1991 added this to the Nextcloud 12.0.6 milestone Feb 8, 2018

@icewind1991 icewind1991 requested review from rullzer and MorrisJobke Feb 8, 2018

@mention-bot

This comment has been minimized.

mention-bot commented Feb 8, 2018

@icewind1991, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Xenopathic to be a potential reviewer.

icewind1991 added some commits Jan 29, 2018

adjust s3 bulk delete to new sdk syntax
Signed-off-by: Robin Appelman <robin@icewind.nl>
fix invalidating folder cache for s3
Signed-off-by: Robin Appelman <robin@icewind.nl>
@codecov

This comment has been minimized.

codecov bot commented Feb 12, 2018

Codecov Report

Merging #8262 into stable12 will decrease coverage by <.01%.
The diff coverage is 0%.

@@              Coverage Diff               @@
##             stable12    #8262      +/-   ##
==============================================
- Coverage       53.84%   53.84%   -0.01%     
- Complexity      22754    22755       +1     
==============================================
  Files            1386     1386              
  Lines           87126    87129       +3     
  Branches         1331     1331              
==============================================
- Hits            46915    46914       -1     
- Misses          40211    40215       +4
Impacted Files Coverage Δ Complexity Δ
apps/files_external/lib/Lib/Storage/AmazonS3.php 0% <0%> (ø) 111 <0> (+1) ⬆️
apps/files_trashbin/lib/Trashbin.php 72.28% <0%> (-0.25%) 136% <0%> (ø)

@rullzer rullzer merged commit 74bc89f into stable12 Feb 13, 2018

1 of 3 checks passed

codecov/patch 0% of diff hit (target 53.84%)
Details
codecov/project 53.84% (-0.01%) compared to 966010f
Details
continuous-integration/drone/pr the build was successful
Details

@rullzer rullzer deleted the s3-folder-delete-12 branch Feb 13, 2018

@MorrisJobke MorrisJobke referenced this pull request Mar 9, 2018

Merged

12.0.6 RC 1 #8750

2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment