New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable13] Better result handling of email search #8267

Merged
merged 1 commit into from Feb 20, 2018

Conversation

Projects
None yet
4 participants
@rullzer
Member

rullzer commented Feb 8, 2018

Backport of #8206

The limit of the response should be respected

@rullzer

This comment has been minimized.

Member

rullzer commented Feb 8, 2018

👍 from me

@MorrisJobke

This comment has been minimized.

Member

MorrisJobke commented Feb 20, 2018

CI fails.

Better result handling of email search
1. Local users should not be returned when searching for empty string
2. The limit of the response should be respected

Signed-off-by: Joas Schilling <coding@schilljs.com>
@codecov

This comment has been minimized.

codecov bot commented Feb 20, 2018

Codecov Report

Merging #8267 into stable13 will increase coverage by <.01%.
The diff coverage is 50%.

@@              Coverage Diff               @@
##             stable13    #8267      +/-   ##
==============================================
+ Coverage       51.22%   51.23%   +<.01%     
  Complexity      24986    24986              
==============================================
  Files            1608     1608              
  Lines           95089    95093       +4     
  Branches         1376     1376              
==============================================
+ Hits            48714    48721       +7     
+ Misses          46375    46372       -3
Impacted Files Coverage Δ Complexity Δ
...ivate/Collaboration/Collaborators/RemotePlugin.php 72.58% <50%> (-0.76%) 17 <0> (ø)
...private/Collaboration/Collaborators/MailPlugin.php 72.34% <50%> (-0.49%) 23 <0> (ø)
core/js/js.js 66.29% <0%> (+0.55%) 0% <0%> (ø) ⬇️
@nickvergessen

This comment has been minimized.

Member

nickvergessen commented Feb 20, 2018

Also fixed here

@blizzz

blizzz approved these changes Feb 20, 2018

@MorrisJobke MorrisJobke merged commit 58cc34b into stable13 Feb 20, 2018

2 of 3 checks passed

codecov/patch 50% of diff hit (target 51.22%)
Details
codecov/project 51.23% (+<.01%) compared to a3de507
Details
continuous-integration/drone/pr the build was successful
Details

@MorrisJobke MorrisJobke deleted the 8206_13 branch Feb 20, 2018

@MorrisJobke MorrisJobke referenced this pull request Mar 9, 2018

Merged

13.0.1 RC1 #8748

10 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment