New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13] Fix styling issues of guest pages #8155 #8286

Merged
merged 3 commits into from Feb 9, 2018

Conversation

Projects
None yet
4 participants
@juliushaertl
Member

juliushaertl commented Feb 9, 2018

backport of #8155

Before:
bildschirmfoto vom 2018-02-02 12-53-07
bildschirmfoto vom 2018-02-02 12-53-23
bildschirmfoto vom 2018-02-02 12-54-09

After:
bildschirmfoto vom 2018-02-02 12-58-37
bildschirmfoto vom 2018-02-02 12-58-22
bildschirmfoto vom 2018-02-02 12-58-01

juliushaertl added some commits Feb 2, 2018

Make sure theming logo css only applies when a logo is set
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Load guest css on any guest and error page
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Add space on guest pages with custom logo
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@codecov

This comment has been minimized.

codecov bot commented Feb 9, 2018

Codecov Report

Merging #8286 into stable13 will decrease coverage by <.01%.
The diff coverage is 0%.

@@              Coverage Diff               @@
##             stable13    #8286      +/-   ##
==============================================
- Coverage       51.24%   51.24%   -0.01%     
- Complexity      24982    24984       +2     
==============================================
  Files            1608     1608              
  Lines           95077    95079       +2     
  Branches         1376     1376              
==============================================
+ Hits            48718    48719       +1     
- Misses          46359    46360       +1
Impacted Files Coverage Δ Complexity Δ
lib/private/TemplateLayout.php 0% <0%> (ø) 48 <0> (+2) ⬆️
lib/private/Server.php 80.66% <0%> (+0.11%) 134% <0%> (ø) ⬇️
@rullzer

rullzer approved these changes Feb 9, 2018

@skjnldsv skjnldsv merged commit 3f91eae into stable13 Feb 9, 2018

2 of 4 checks passed

codecov/patch 0% of diff hit (target 51.24%)
Details
codecov/project 51.24% (-0.01%) compared to 9c9c438
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/drone/push the build was successful
Details

@skjnldsv skjnldsv deleted the stable13-8155 branch Feb 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment