New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable13] Make acceptance tests for comments more consistent with the others #8395

merged 4 commits into from Feb 16, 2018


None yet
2 participants

danxuliu commented Feb 16, 2018

Backport of #8382

The typo in .drone.yml in the original pull request is already fixed in this backport.

danxuliu added some commits Feb 15, 2018

Add acceptance tests for comments to Drone
Signed-off-by: Daniel Calviño Sánchez <>
Move locators above step definitions
The locators are moved above the step definitions for consistency with
other context files; besides that I made some minor adjustments for
consistency too in the locator descriptions and identation, and moved
the locators for ".newCommentRow" descendants together.

Signed-off-by: Daniel Calviño Sánchez <>
Adjust timeouts in the step to create a new comment
Depending on the previous steps the new comment field may be already
shown or not when the step to create a new comment is executed.
Therefore, the timeout was increased from 2 to the "standard" 10 seconds
used in other tests.

If the new comment field was found there is no need to use a timeout
when looking for the new comment button; it is either there or not, it
will not appear after some time.

Signed-off-by: Daniel Calviño Sánchez <>
Take into account the comment message when looking for it
Instead of checking that the list contains one comment it is now checked
that a comment with certain message is visible. This makes the step (and
the locator) more reusable in future tests and also simplifies the code.

Signed-off-by: Daniel Calviño Sánchez <>

This comment has been minimized.

codecov bot commented Feb 16, 2018

Codecov Report

Merging #8395 into stable13 will increase coverage by <.01%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             stable13    #8395      +/-   ##
+ Coverage       51.23%   51.23%   +<.01%     
  Complexity      24986    24986              
  Files            1608     1608              
  Lines           95089    95089              
  Branches         1376     1376              
+ Hits            48718    48721       +3     
+ Misses          46371    46368       -3
Impacted Files Coverage Δ Complexity Δ
lib/private/Server.php 80.66% <0%> (+0.11%) 134% <0%> (ø) ⬇️
apps/files_trashbin/lib/Trashbin.php 72.53% <0%> (+0.24%) 136% <0%> (ø) ⬇️
lib/private/Files/Cache/Propagator.php 96.2% <0%> (+1.26%) 16% <0%> (ø) ⬇️

@MorrisJobke MorrisJobke merged commit 964b511 into stable13 Feb 16, 2018

4 checks passed

codecov/patch Coverage not affected when comparing de9865b...5fd7de5
codecov/project 51.23% (+<.01%) compared to de9865b
continuous-integration/drone/pr the build was successful
continuous-integration/drone/push the build was successful

@MorrisJobke MorrisJobke deleted the stable13-8382-make-acceptance-tests-for-comments-more-consistent-with-the-others branch Feb 16, 2018

@MorrisJobke MorrisJobke referenced this pull request Mar 9, 2018


13.0.1 RC1 #8748

10 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment