New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable13] Fix edit tag textbox size #8407

Merged
merged 1 commit into from Feb 17, 2018

Conversation

Projects
None yet
3 participants
@AasthaGupta
Member

AasthaGupta commented Feb 17, 2018

Backport of #8376

Fix edit tag textbox size
Fixes #7586

Signed-off-by: Aastha Gupta <aastha.gupta4104@gmail.com>
@codecov

This comment has been minimized.

codecov bot commented Feb 17, 2018

Codecov Report

Merging #8407 into stable13 will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             stable13    #8407   +/-   ##
===========================================
  Coverage       51.23%   51.23%           
  Complexity      24986    24986           
===========================================
  Files            1608     1608           
  Lines           95089    95089           
  Branches         1376     1376           
===========================================
  Hits            48718    48718           
  Misses          46371    46371
@danxuliu

Tested and works 👍

However, I have noticed that the final height of the input field is 32px instead of 30px; this is caused by the min-height rule applied to input elements in the server. Anyway, works for me ;-)

@MorrisJobke MorrisJobke merged commit 577a3cf into stable13 Feb 17, 2018

4 checks passed

codecov/patch Coverage not affected when comparing b631cc1...09dbcd9
Details
codecov/project 51.23% remains the same compared to b631cc1
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/drone/push the build was successful
Details

@MorrisJobke MorrisJobke deleted the stable13-8376-devgals branch Feb 17, 2018

@MorrisJobke MorrisJobke referenced this pull request Mar 9, 2018

Merged

13.0.1 RC1 #8748

10 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment