New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable12] Fix edit tag textbox size #8408

Merged
merged 1 commit into from Feb 17, 2018

Conversation

Projects
None yet
3 participants
@AasthaGupta
Member

AasthaGupta commented Feb 17, 2018

Backport of #8376

Fix edit tag textbox size
Fixes #7586

Signed-off-by: Aastha Gupta <aastha.gupta4104@gmail.com>
@codecov

This comment has been minimized.

codecov bot commented Feb 17, 2018

Codecov Report

Merging #8408 into stable12 will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             stable12    #8408   +/-   ##
===========================================
  Coverage       53.84%   53.84%           
  Complexity      22755    22755           
===========================================
  Files            1386     1386           
  Lines           87129    87129           
  Branches         1331     1331           
===========================================
  Hits            46915    46915           
  Misses          40214    40214
Impacted Files Coverage Δ Complexity Δ
lib/private/Server.php 84.68% <0%> (-0.13%) 121% <0%> (ø)
lib/private/Security/CertificateManager.php 92.07% <0%> (+0.99%) 39% <0%> (ø) ⬇️
@danxuliu

Tested and works 👍

However, I have noticed that the final height of the input field is 32px instead of 30px; this is caused by the min-height rule applied to input elements in the server. Anyway, works for me ;-)

@MorrisJobke MorrisJobke merged commit 3ab9919 into stable12 Feb 17, 2018

3 checks passed

codecov/patch Coverage not affected when comparing 245eded...39a5136
Details
codecov/project 53.84% remains the same compared to 245eded
Details
continuous-integration/drone/push the build was successful
Details

@MorrisJobke MorrisJobke deleted the stable12-8376-devgals branch Feb 17, 2018

@MorrisJobke MorrisJobke referenced this pull request Mar 9, 2018

Merged

12.0.6 RC 1 #8750

2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment