New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable13] Fix hiding and event propagation issues with the user management popover #8517

Merged
merged 1 commit into from Feb 23, 2018

Conversation

Projects
None yet
3 participants
@juliushaertl
Member

juliushaertl commented Feb 23, 2018

backport of #8416

This PR fixes the issues from #8401 as well as the popovermenu not being closed when clicking the more icon again.

Removing the additional .menu and .bubble classes takes care that event propagation will not be stopped by the menu handling from core/js/js.js, since the user management has implemented its own code to show/hide popovers.

Fix hiding and event propagation issues with the user management popover
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@nickvergessen

This comment has been minimized.

Member

nickvergessen commented Feb 23, 2018

Fixes impersonate app :)

@blizzz

blizzz approved these changes Feb 23, 2018

@blizzz blizzz merged commit a4fbe80 into stable13 Feb 23, 2018

2 checks passed

continuous-integration/drone/pr the build was successful
Details
continuous-integration/drone/push the build was successful
Details

@blizzz blizzz deleted the stable13-8416 branch Feb 23, 2018

@MorrisJobke MorrisJobke referenced this pull request Mar 9, 2018

Merged

13.0.1 RC1 #8748

10 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment