New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable13] Avoid fruitless login attempts #8532

Merged
merged 2 commits into from Feb 26, 2018

Conversation

@blizzz
Member

blizzz commented Feb 26, 2018

Backport from #8499

blizzz added some commits Feb 22, 2018

track the state of the bind result
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
don't try login with the same name that just failed
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@codecov

This comment has been minimized.

codecov bot commented Feb 26, 2018

Codecov Report

Merging #8532 into stable13 will decrease coverage by <.01%.
The diff coverage is 56.52%.

@@              Coverage Diff               @@
##             stable13    #8532      +/-   ##
==============================================
- Coverage       51.23%   51.22%   -0.01%     
- Complexity      24987    24991       +4     
==============================================
  Files            1608     1608              
  Lines           95100    95117      +17     
  Branches         1376     1376              
==============================================
+ Hits            48721    48723       +2     
- Misses          46379    46394      +15
Impacted Files Coverage Δ Complexity Δ
core/Controller/LoginController.php 79.57% <100%> (+0.85%) 40 <0> (+1) ⬆️
apps/user_ldap/lib/Connection.php 55.04% <47.36%> (-2.84%) 122 <0> (+3)

@MorrisJobke MorrisJobke merged commit 88ece3f into stable13 Feb 26, 2018

3 checks passed

codecov/patch 56.52% of diff hit (target 51.23%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +5.29% compared to 7e424e5
Details
continuous-integration/drone/pr the build was successful
Details

@MorrisJobke MorrisJobke deleted the 8499-stable13 branch Feb 26, 2018

@MorrisJobke MorrisJobke referenced this pull request Mar 9, 2018

Merged

13.0.1 RC1 #8748

10 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment