New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable13] Fix retrieval of group members with numerical uids from LDAP #8536

Merged
merged 2 commits into from Feb 26, 2018

Conversation

Projects
None yet
3 participants
@blizzz
Member

blizzz commented Feb 26, 2018

backport from #8522

blizzz added some commits Feb 23, 2018

tests for retrieving group members with numerical uids
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
fix retrieving group members with numerical uids from LDAP
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@codecov

This comment has been minimized.

codecov bot commented Feb 26, 2018

Codecov Report

Merging #8536 into stable13 will increase coverage by <.01%.
The diff coverage is 100%.

@@              Coverage Diff               @@
##             stable13    #8536      +/-   ##
==============================================
+ Coverage       51.23%   51.23%   +<.01%     
  Complexity      24987    24987              
==============================================
  Files            1608     1608              
  Lines           95100    95100              
  Branches         1376     1376              
==============================================
+ Hits            48721    48722       +1     
+ Misses          46379    46378       -1
Impacted Files Coverage Δ Complexity Δ
apps/user_ldap/lib/Group_LDAP.php 62.03% <100%> (ø) 176 <0> (ø) ⬇️
apps/files_trashbin/lib/Trashbin.php 72.53% <0%> (+0.24%) 136% <0%> (ø) ⬇️

@MorrisJobke MorrisJobke merged commit bf2f744 into stable13 Feb 26, 2018

3 checks passed

codecov/patch 100% of diff hit (target 51.23%)
Details
codecov/project 51.23% (+<.01%) compared to 7e424e5
Details
continuous-integration/drone/pr the build was successful
Details

@MorrisJobke MorrisJobke deleted the 8522-stable13 branch Feb 26, 2018

@MorrisJobke MorrisJobke referenced this pull request Mar 9, 2018

Merged

13.0.1 RC1 #8748

10 of 10 tasks complete

@tanguy-opendsi tanguy-opendsi referenced this pull request May 7, 2018

Closed

occ ldap_user issue #9394

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment