New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable13] Fix upload button visible on read-only folders #8595

Merged
merged 1 commit into from Mar 1, 2018

Conversation

Projects
None yet
3 participants
@danxuliu
Member

danxuliu commented Mar 1, 2018

Backport of #8589

Fix upload button visible on read-only folders
The div that contains the elements related to the creation of new files,
and thus the upload button, is always present in the DOM; it is hidden
or shown based on the folder permissions by adding or removing the
"hidden" CSS class. However, as the other CSS classes for the div are
"actions" and "creatable" and a "display: flex" rule was defined for
".actions.creatable" below the "display: none" rule for
".actions.hidden" the last one took precedence and the div ended being
always visible, even if the "hidden" CSS class was set. Now the rules
for the ".actions.hidden" selector are defined below the rules for the
".actions.creatable" selector and thus the "display: none" rule is
applied as expected.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

@danxuliu danxuliu added this to the Nextcloud 13.0.1 milestone Mar 1, 2018

@danxuliu danxuliu requested review from rullzer, MorrisJobke and skjnldsv Mar 1, 2018

@danxuliu danxuliu changed the title from Fix upload button visible on read-only folders to [stable13] Fix upload button visible on read-only folders Mar 1, 2018

@MorrisJobke MorrisJobke merged commit 5a20f64 into stable13 Mar 1, 2018

0 of 2 checks passed

continuous-integration/drone/pr the build failed
Details
continuous-integration/drone/push the build failed
Details

@MorrisJobke MorrisJobke deleted the stable13-8589-fix-upload-button-visible-on-read-only-folders branch Mar 1, 2018

@MorrisJobke MorrisJobke referenced this pull request Mar 9, 2018

Merged

13.0.1 RC1 #8748

10 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment