New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable13] Fix comments (and systemtags) when involving users with numerical ids #8615

Merged
merged 1 commit into from Mar 2, 2018

Conversation

@blizzz
Member

blizzz commented Mar 1, 2018

backport of #8355 to stable13

backport of #8355 to stable13
test creating comments with numeric user ids

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

fix creating comments when file is accessible to users with numeric ids

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

tests for systemtags related to numeric user ids

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

fix systemtags event with numeric user ids

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@codecov

This comment has been minimized.

codecov bot commented Mar 2, 2018

Codecov Report

Merging #8615 into stable13 will increase coverage by 0.07%.
The diff coverage is 94%.

@@              Coverage Diff               @@
##             stable13    #8615      +/-   ##
==============================================
+ Coverage       51.22%   51.29%   +0.07%     
- Complexity      24992    24994       +2     
==============================================
  Files            1608     1609       +1     
  Lines           95126    95223      +97     
  Branches         1376     1376              
==============================================
+ Hits            48726    48848     +122     
+ Misses          46400    46375      -25
Impacted Files Coverage Δ Complexity Δ
apps/systemtags/lib/Activity/Listener.php 0% <0%> (ø) 33 <0> (ø) ⬇️
apps/comments/lib/Activity/Listener.php 80.39% <100%> (+56.86%) 10 <0> (ø) ⬇️
apps/comments/tests/Unit/Activity/ListenerTest.php 95.83% <95.83%> (ø) 2 <2> (?)
core/js/js.js 66.4% <0%> (+0.11%) 0% <0%> (ø) ⬇️
@rullzer

rullzer approved these changes Mar 2, 2018

@MorrisJobke

🐘

@MorrisJobke MorrisJobke merged commit 59d6f45 into stable13 Mar 2, 2018

4 checks passed

codecov/patch 94% of diff hit (target 51.22%)
Details
codecov/project 51.29% (+0.07%) compared to a2672a2
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/drone/push the build was successful
Details

@MorrisJobke MorrisJobke deleted the stable13-8355 branch Mar 2, 2018

@MorrisJobke MorrisJobke referenced this pull request Mar 9, 2018

Merged

13.0.1 RC1 #8748

10 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment