New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable12] Fix comments (and systemtags) when involving users with numerical ids #8616

Merged
merged 1 commit into from Mar 2, 2018

Conversation

@blizzz
Member

blizzz commented Mar 1, 2018

backport of #8355 to stable12

backport of #8355 to stable12
test creating comments with numeric user ids

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

fix creating comments when file is accessible to users with numeric ids

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

tests for systemtags related to numeric user ids

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

fix systemtags event with numeric user ids

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

@blizzz blizzz added this to the Nextcloud 12.0.6 milestone Mar 1, 2018

@blizzz blizzz changed the title from [stable13] Fix comments (and systemtags) when involving users with numerical ids to [stable12] Fix comments (and systemtags) when involving users with numerical ids Mar 1, 2018

@rullzer

rullzer approved these changes Mar 2, 2018

@codecov

This comment has been minimized.

codecov bot commented Mar 2, 2018

Codecov Report

Merging #8616 into stable12 will increase coverage by 0.08%.
The diff coverage is 94%.

@@              Coverage Diff               @@
##             stable12    #8616      +/-   ##
==============================================
+ Coverage       53.84%   53.92%   +0.08%     
- Complexity      22762    22764       +2     
==============================================
  Files            1386     1387       +1     
  Lines           87154    87251      +97     
  Branches         1331     1331              
==============================================
+ Hits            46930    47053     +123     
+ Misses          40224    40198      -26
Impacted Files Coverage Δ Complexity Δ
apps/systemtags/lib/Activity/Listener.php 0% <0%> (ø) 33 <0> (ø) ⬇️
apps/comments/lib/Activity/Listener.php 80.39% <100%> (+56.86%) 10 <0> (ø) ⬇️
apps/comments/tests/Unit/Activity/ListenerTest.php 95.83% <95.83%> (ø) 2 <2> (?)
core/js/js.js 61.94% <0%> (+0.11%) 0% <0%> (ø) ⬇️
lib/private/Files/Cache/Propagator.php 96.2% <0%> (+1.26%) 16% <0%> (ø) ⬇️
@MorrisJobke

🐘

@MorrisJobke MorrisJobke merged commit b031ead into stable12 Mar 2, 2018

4 checks passed

codecov/patch 94% of diff hit (target 53.84%)
Details
codecov/project 53.92% (+0.08%) compared to ec18b5e
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/drone/push the build was successful
Details

@MorrisJobke MorrisJobke deleted the stable12-8355 branch Mar 2, 2018

@MorrisJobke MorrisJobke referenced this pull request Mar 9, 2018

Merged

12.0.6 RC 1 #8750

2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment