New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13] Properly encapsulate require_once for app.php #8631

Merged
merged 2 commits into from Mar 5, 2018

Conversation

Projects
None yet
3 participants
@juliushaertl
Member

juliushaertl commented Mar 2, 2018

If an app has an appinfo/app.php file, that includes a variable called $app, this would lead to a type error when calling getAppInfo otherwise.

Backport of #8372

juliushaertl added some commits Feb 15, 2018

Properly encapsulate require_once for app.php
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Add throws annotation
Signed-off-by: Julius Härtl <jus@bitgrid.net>

@juliushaertl juliushaertl added this to the Nextcloud 13.0.1 milestone Mar 2, 2018

@juliushaertl juliushaertl changed the title from Properly encapsulate require_once for app.php to [13] Properly encapsulate require_once for app.php Mar 2, 2018

@rullzer

rullzer approved these changes Mar 2, 2018

@nickvergessen nickvergessen merged commit 479b946 into stable13 Mar 5, 2018

1 of 2 checks passed

continuous-integration/drone/push the build failed
Details
continuous-integration/drone/pr the build was successful
Details

@nickvergessen nickvergessen deleted the stable13-8372 branch Mar 5, 2018

@MorrisJobke MorrisJobke referenced this pull request Mar 9, 2018

Merged

13.0.1 RC1 #8748

10 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment