New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[12] Properly encapsulate require_once for app.php #8632
Conversation
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Codecov Report
@@ Coverage Diff @@
## stable12 #8632 +/- ##
==============================================
+ Coverage 53.92% 53.92% +<.01%
Complexity 22764 22764
==============================================
Files 1387 1387
Lines 87251 87251
Branches 1331 1331
==============================================
+ Hits 47050 47051 +1
+ Misses 40201 40200 -1
|
@@ -133,6 +133,7 @@ public static function loadApps($types = null) { | |||
* load a single app | |||
* | |||
* @param string $app | |||
* @throws Exception |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still true?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. This is another exception outside of this try catch.
If an app has an appinfo/app.php file, that includes a variable called $app, this would lead to a type error when calling getAppInfo otherwise.
Backport of #8372