New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable13] AppData hardening #8636

Merged
merged 1 commit into from Mar 5, 2018

Conversation

Projects
None yet
3 participants
@rullzer
Member

rullzer commented Mar 2, 2018

Backport of #8289

Hardening of SimpleFile getContent
if file_get_contents fails remove the file. And traverse up the tree
checking if the other folders are there.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@codecov

This comment has been minimized.

codecov bot commented Mar 2, 2018

Codecov Report

Merging #8636 into stable13 will increase coverage by <.01%.
The diff coverage is 100%.

@@              Coverage Diff               @@
##             stable13    #8636      +/-   ##
==============================================
+ Coverage       51.29%   51.29%   +<.01%     
- Complexity      24994    24998       +4     
==============================================
  Files            1609     1609              
  Lines           95223    95234      +11     
  Branches         1376     1376              
==============================================
+ Hits            48842    48853      +11     
  Misses          46381    46381
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/SimpleFS/SimpleFile.php 100% <100%> (ø) 13 <3> (+4) ⬆️

@nickvergessen nickvergessen merged commit 6104a70 into stable13 Mar 5, 2018

3 checks passed

codecov/patch 100% of diff hit (target 51.29%)
Details
codecov/project 51.29% (+<.01%) compared to 364e7fe
Details
continuous-integration/drone/pr the build was successful
Details

@nickvergessen nickvergessen deleted the 8289_13 branch Mar 5, 2018

@MorrisJobke MorrisJobke referenced this pull request Mar 9, 2018

Merged

13.0.1 RC1 #8748

10 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment