New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable13] do not create empty userid when attribute does not have allowed chars #8673

Merged
merged 1 commit into from Mar 6, 2018

Conversation

Projects
None yet
3 participants
@blizzz
Member

blizzz commented Mar 5, 2018

backport of #8634

do not create empty userid when attribute does not have allowed chars
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

@blizzz blizzz added this to the Nextcloud 13.0.1 milestone Mar 5, 2018

@blizzz blizzz requested review from rullzer and MorrisJobke Mar 5, 2018

@codecov

This comment has been minimized.

codecov bot commented Mar 5, 2018

Codecov Report

Merging #8673 into stable13 will increase coverage by <.01%.
The diff coverage is 53.33%.

@@              Coverage Diff              @@
##             stable13   #8673      +/-   ##
=============================================
+ Coverage        51.3%   51.3%   +<.01%     
- Complexity      24998   25001       +3     
=============================================
  Files            1609    1609              
  Lines           95234   95246      +12     
  Branches         1376    1376              
=============================================
+ Hits            48857   48867      +10     
- Misses          46377   46379       +2
Impacted Files Coverage Δ Complexity Δ
apps/user_ldap/lib/Access.php 36.18% <53.33%> (+0.57%) 319 <0> (+3) ⬆️
apps/files_trashbin/lib/Trashbin.php 72.53% <0%> (+0.24%) 136% <0%> (ø) ⬇️
@rullzer

rullzer approved these changes Mar 6, 2018

@MorrisJobke MorrisJobke merged commit 0667a32 into stable13 Mar 6, 2018

4 checks passed

codecov/patch 53.33% of diff hit (target 51.3%)
Details
codecov/project 51.3% (+<.01%) compared to 655e39f
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/drone/push the build was successful
Details

@MorrisJobke MorrisJobke deleted the stable13-8634 branch Mar 6, 2018

@MorrisJobke MorrisJobke referenced this pull request Mar 9, 2018

Merged

13.0.1 RC1 #8748

10 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment