New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable13] generate different UIDs for Birthday, Anniversary and Death event #8678

Merged
merged 1 commit into from Mar 6, 2018

Conversation

Projects
None yet
4 participants
@rullzer
Member

rullzer commented Mar 6, 2018

Backport of #7707

generate different UIDs for Birthday, Anniversary and Death event
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
@codecov

This comment has been minimized.

codecov bot commented Mar 6, 2018

Codecov Report

Merging #8678 into stable13 will decrease coverage by 0.17%.
The diff coverage is 100%.

@@              Coverage Diff               @@
##             stable13    #8678      +/-   ##
==============================================
- Coverage        51.3%   51.12%   -0.18%     
- Complexity      24998    25088      +90     
==============================================
  Files            1609     1609              
  Lines           95236    95568     +332     
  Branches         1376     1376              
==============================================
- Hits            48858    48857       -1     
- Misses          46378    46711     +333
Impacted Files Coverage Δ Complexity Δ
apps/dav/lib/CalDAV/BirthdayService.php 81.29% <100%> (ø) 44 <12> (ø) ⬇️
apps/user_ldap/lib/Access.php 25.32% <0%> (-10.3%) 406% <0%> (+90%)
apps/files_trashbin/lib/Trashbin.php 72.28% <0%> (-0.25%) 136% <0%> (ø)

@MorrisJobke MorrisJobke merged commit 16fa18a into stable13 Mar 6, 2018

3 checks passed

codecov/patch 100% of diff hit (target 51.3%)
Details
codecov/project Absolute coverage decreased by -0.17% but relative coverage increased by +48.69% compared to ff7237a
Details
continuous-integration/drone/pr the build was successful
Details

@MorrisJobke MorrisJobke deleted the 7707_13 branch Mar 6, 2018

@MorrisJobke MorrisJobke referenced this pull request Mar 9, 2018

Merged

13.0.1 RC1 #8748

10 of 10 tasks complete

@georgehrke georgehrke referenced this pull request May 1, 2018

Closed

Changes are not saved #533

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment