New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13] disable part files for object stores #8725

Merged
merged 2 commits into from Mar 9, 2018

Conversation

Projects
None yet
3 participants
@icewind1991
Member

icewind1991 commented Mar 8, 2018

Backport of #8715

icewind1991 added some commits Mar 7, 2018

disable part files for object stores
Signed-off-by: Robin Appelman <robin@icewind.nl>
emit pre-hooks earlier when not using part files
Signed-off-by: Robin Appelman <robin@icewind.nl>

@icewind1991 icewind1991 added this to the Nextcloud 13.0.1 milestone Mar 8, 2018

@icewind1991 icewind1991 requested review from rullzer and MorrisJobke Mar 8, 2018

@codecov

This comment has been minimized.

codecov bot commented Mar 8, 2018

Codecov Report

Merging #8725 into stable13 will decrease coverage by <.01%.
The diff coverage is 25%.

@@              Coverage Diff               @@
##             stable13    #8725      +/-   ##
==============================================
- Coverage        51.3%   51.29%   -0.01%     
- Complexity      25017    25019       +2     
==============================================
  Files            1609     1609              
  Lines           95285    95285              
  Branches         1376     1376              
==============================================
- Hits            48883    48881       -2     
- Misses          46402    46404       +2
Impacted Files Coverage Δ Complexity Δ
...b/private/Files/ObjectStore/ObjectStoreStorage.php 66.39% <0%> (-0.56%) 75 <1> (+1)
apps/dav/lib/Connector/Sabre/File.php 74.04% <50%> (+0.18%) 102 <0> (+1) ⬆️
apps/files_trashbin/lib/Trashbin.php 72.28% <0%> (-0.25%) 136% <0%> (ø)
@rullzer

rullzer approved these changes Mar 8, 2018

@MorrisJobke MorrisJobke referenced this pull request Mar 9, 2018

Merged

13.0.1 RC1 #8748

10 of 10 tasks complete

@MorrisJobke MorrisJobke merged commit 4fa0cac into stable13 Mar 9, 2018

1 of 3 checks passed

codecov/patch 25% of diff hit (target 51.3%)
Details
codecov/project 51.29% (-0.01%) compared to d7a70ab
Details
continuous-integration/drone/pr the build was successful
Details

@MorrisJobke MorrisJobke deleted the objectstore-no-part-files-13 branch Mar 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment