New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable13] Check if the cached js file exists #8746

Merged
merged 2 commits into from Mar 9, 2018

Conversation

Projects
None yet
3 participants
@rullzer
Member

rullzer commented Mar 9, 2018

backport #8714

rullzer added some commits Mar 7, 2018

Check if the cached js file exists
Fixes #8705

If the file does not exist (for whatever reason). It is never cached. No
matter what the depscache etc tell you.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Fix tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

@rullzer rullzer added this to the Nextcloud 13.0.1 milestone Mar 9, 2018

@MorrisJobke MorrisJobke referenced this pull request Mar 9, 2018

Merged

13.0.1 RC1 #8748

10 of 10 tasks complete
@codecov

This comment has been minimized.

codecov bot commented Mar 9, 2018

Codecov Report

Merging #8746 into stable13 will decrease coverage by <.01%.
The diff coverage is 100%.

@@              Coverage Diff              @@
##             stable13   #8746      +/-   ##
=============================================
- Coverage        51.3%   51.3%   -0.01%     
- Complexity      25017   25018       +1     
=============================================
  Files            1609    1609              
  Lines           95285   95288       +3     
  Branches         1376    1376              
=============================================
+ Hits            48882   48883       +1     
- Misses          46403   46405       +2
Impacted Files Coverage Δ Complexity Δ
lib/private/Template/JSCombiner.php 87.5% <100%> (-1.61%) 31 <0> (+1)

@juliushaertl juliushaertl merged commit e2728aa into stable13 Mar 9, 2018

3 checks passed

codecov/patch 100% of diff hit (target 51.3%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +48.69% compared to d1547ee
Details
continuous-integration/drone/pr the build was successful
Details

@juliushaertl juliushaertl deleted the 8705_13 branch Mar 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment