New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable13] Fix integer overflow in ChunkingPlugin #8752

Merged
merged 1 commit into from Mar 9, 2018

Conversation

Projects
None yet
2 participants
@MorrisJobke
Member

MorrisJobke commented Mar 9, 2018

Avoids errors when the size exceeds MAX_INT because of the cast to int. Better cast it to float to avoid this.

Backport of #8112

Fix integer overflow in ChunkingPlugin
Avoids errors when the size exceeds MAX_INT because of the cast to int. Better cast it to float to avoid this.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@nickvergessen

Same code as in master

@codecov

This comment has been minimized.

codecov bot commented Mar 9, 2018

Codecov Report

Merging #8752 into stable13 will decrease coverage by <.01%.
The diff coverage is 100%.

@@              Coverage Diff               @@
##             stable13    #8752      +/-   ##
==============================================
- Coverage        51.3%   51.29%   -0.01%     
- Complexity      25017    25020       +3     
==============================================
  Files            1609     1609              
  Lines           95285    95288       +3     
  Branches         1376     1376              
==============================================
  Hits            48882    48882              
- Misses          46403    46406       +3
Impacted Files Coverage Δ Complexity Δ
apps/dav/lib/Upload/ChunkingPlugin.php 96.29% <100%> (ø) 8 <0> (ø) ⬇️
lib/private/Template/JSCombiner.php 87.5% <0%> (-1.61%) 31% <0%> (+1%)
...b/private/Files/ObjectStore/ObjectStoreStorage.php 66.39% <0%> (-0.56%) 75% <0%> (+1%)
apps/dav/lib/Connector/Sabre/File.php 74.04% <0%> (+0.18%) 102% <0%> (+1%) ⬆️
@MorrisJobke

This comment has been minimized.

Member

MorrisJobke commented Mar 9, 2018

Also 👍 from me, because I only did a straight cherry-pick

@MorrisJobke MorrisJobke merged commit 0f1567d into stable13 Mar 9, 2018

3 checks passed

codecov/patch 100% of diff hit (target 51.3%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +48.69% compared to d1547ee
Details
continuous-integration/drone/pr the build was successful
Details

@MorrisJobke MorrisJobke deleted the 13-8112 branch Mar 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment