New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable12] group existence check works without attribute (like with users) #8850

Merged
merged 1 commit into from Mar 16, 2018

Conversation

Projects
None yet
3 participants
@blizzz
Member

blizzz commented Mar 16, 2018

backport of #8835

existence check works without attribute (like with users)
cn is not necessarily given everywhere

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

@blizzz blizzz added this to the Nextcloud 12.0.7 milestone Mar 16, 2018

@blizzz blizzz requested review from rullzer and MorrisJobke Mar 16, 2018

@codecov

This comment has been minimized.

codecov bot commented Mar 16, 2018

Codecov Report

Merging #8850 into stable12 will not change coverage.
The diff coverage is 0%.

@@             Coverage Diff             @@
##             stable12    #8850   +/-   ##
===========================================
  Coverage       53.91%   53.91%           
  Complexity      22779    22779           
===========================================
  Files            1387     1387           
  Lines           87285    87285           
  Branches         1331     1331           
===========================================
  Hits            47062    47062           
  Misses          40223    40223
Impacted Files Coverage Δ Complexity Δ
apps/user_ldap/lib/Access.php 19.25% <0%> (ø) 308 <0> (ø) ⬇️

@rullzer rullzer merged commit 0c501a8 into stable12 Mar 16, 2018

2 of 3 checks passed

codecov/patch 0% of diff hit (target 53.91%)
Details
codecov/project 53.91% remains the same compared to e8dbfc1
Details
continuous-integration/drone/pr the build was successful
Details

@rullzer rullzer deleted the backport/8835/stable12 branch Mar 16, 2018

@MorrisJobke MorrisJobke referenced this pull request Apr 18, 2018

Merged

12.0.7 RC 1 #9229

3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment