New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable13] Show EOL warning in the update section #8986

Merged
merged 1 commit into from Apr 18, 2018

Conversation

Projects
None yet
3 participants
@nickvergessen
Member

nickvergessen commented Mar 26, 2018

Backport #8821

@MorrisJobke

Tested and works 👍

@MorrisJobke

This comment has been minimized.

Member

MorrisJobke commented Apr 12, 2018

Rebased to retrigger CI

@codecov

This comment has been minimized.

codecov bot commented Apr 12, 2018

Codecov Report

Merging #8986 into stable13 will decrease coverage by 16.68%.
The diff coverage is 0%.

@@               Coverage Diff               @@
##             stable13    #8986       +/-   ##
===============================================
- Coverage       51.33%   34.64%   -16.69%     
- Complexity      25040    25042        +2     
===============================================
  Files            1609     1609               
  Lines           95317    95325        +8     
  Branches         1376     1376               
===============================================
- Hits            48929    33030    -15899     
- Misses          46388    62295    +15907
Impacted Files Coverage Δ Complexity Δ
...atenotification/lib/Controller/AdminController.php 0% <0%> (-66.67%) 12 <0> (+1)
apps/updatenotification/templates/admin.php 0% <0%> (ø) 0 <0> (ø) ⬇️
lib/private/Updater/VersionCheck.php 0% <0%> (-92.11%) 8 <0> (+1)
apps/updatenotification/lib/UpdateChecker.php 0% <0%> (-75%) 9 <0> (ø)
...te/Authentication/LoginCredentials/Credentials.php 0% <0%> (-100%) 4% <0%> (ø)
...s/dav/lib/CalDAV/BirthdayCalendar/EnablePlugin.php 0% <0%> (-100%) 7% <0%> (ø)
...ty/Exceptions/CrossSiteRequestForgeryException.php 0% <0%> (-100%) 1% <0%> (ø)
...curity/Exceptions/StrictCookieMissingException.php 0% <0%> (-100%) 1% <0%> (ø)
apps/dav/lib/CalDAV/Activity/Setting/Calendar.php 0% <0%> (-100%) 8% <0%> (ø)
lib/private/App/AppStore/Version/Version.php 0% <0%> (-100%) 3% <0%> (ø)
... and 526 more
Show EOL warning in the update section
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen

This comment has been minimized.

Member

nickvergessen commented Apr 18, 2018

Rebased and fixed the last failing test

@MorrisJobke MorrisJobke referenced this pull request Apr 18, 2018

Merged

13.0.2 RC 1 #9228

8 of 11 tasks complete

@rullzer rullzer merged commit cbe03cb into stable13 Apr 18, 2018

1 check failed

continuous-integration/drone/pr the build failed
Details

@rullzer rullzer deleted the backport/8821/show-eol-warning branch Apr 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment