New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable12] Show EOL warning in the update section #8987

Merged
merged 1 commit into from Apr 18, 2018

Conversation

Projects
None yet
3 participants
@nickvergessen
Member

nickvergessen commented Mar 26, 2018

Backport #8986

@@ -107,14 +107,14 @@ public function displayPanel() {
$notifyGroups = json_decode($this->config->getAppValue('updatenotification', 'notify_groups', '["admin"]'), true);
$params = [
'isNewVersionAvailable' => !empty($updateState['updateAvailable']),
'isNewVersionAvailable' => true, //!empty($updateState['updateAvailable']),

This comment has been minimized.

@MorrisJobke

MorrisJobke Apr 12, 2018

Member

🙈 let me fix this

@codecov

This comment has been minimized.

codecov bot commented Apr 12, 2018

Codecov Report

Merging #8987 into stable12 will decrease coverage by <.01%.
The diff coverage is 33.33%.

@@              Coverage Diff               @@
##             stable12    #8987      +/-   ##
==============================================
- Coverage       53.91%   53.91%   -0.01%     
- Complexity      22780    22782       +2     
==============================================
  Files            1387     1387              
  Lines           87286    87295       +9     
  Branches         1331     1331              
==============================================
+ Hits            47063    47065       +2     
- Misses          40223    40230       +7
Impacted Files Coverage Δ Complexity Δ
apps/updatenotification/templates/admin.php 0% <0%> (ø) 0 <0> (ø) ⬇️
lib/private/Updater/VersionCheck.php 92.5% <100%> (+0.19%) 8 <0> (+1) ⬆️
...atenotification/lib/Controller/AdminController.php 64.4% <100%> (+0.61%) 12 <0> (+1) ⬆️
apps/updatenotification/lib/UpdateChecker.php 76.19% <100%> (+1.19%) 9 <0> (ø) ⬇️
apps/files_trashbin/lib/Trashbin.php 72.28% <0%> (-0.25%) 136% <0%> (ø)
@MorrisJobke

Rebased and fixed the typo. And works 👍

Show EOL warning in the update section
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen

This comment has been minimized.

Member

nickvergessen commented Apr 18, 2018

Rebased and fixed the last failing test

@MorrisJobke MorrisJobke referenced this pull request Apr 18, 2018

Merged

12.0.7 RC 1 #9229

3 of 3 tasks complete

@rullzer rullzer merged commit d39f00a into stable12 Apr 18, 2018

1 of 3 checks passed

codecov/patch 33.33% of diff hit (target 53.91%)
Details
codecov/project 53.91% (-0.01%) compared to f7d6eb9
Details
continuous-integration/drone/pr the build was successful
Details

@rullzer rullzer deleted the backport/8821/show-eol-warning-12 branch Apr 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment