New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable13] Use app version to generate scss filename #9015

Merged
merged 1 commit into from Apr 3, 2018

Conversation

@skjnldsv
Member

skjnldsv commented Mar 28, 2018

backport #8999

Use app version to generate scss filename
Fixed scsscacher tests

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

@skjnldsv skjnldsv added this to the Nextcloud 13.0.2 milestone Mar 28, 2018

@skjnldsv skjnldsv self-assigned this Mar 28, 2018

@skjnldsv skjnldsv changed the title from [stable13] Use app version to generate scss filename #8999 to [stable13] Use app version to generate scss filename Mar 28, 2018

@kyrofa

This comment has been minimized.

Member

kyrofa commented Mar 28, 2018

This one I'm able to test! Unfortunately, when snapped and using a datadirectory in /media, the CSS cache still doesn't look right after upgrade from 12 to this PR:

image

@codecov

This comment has been minimized.

codecov bot commented Mar 28, 2018

Codecov Report

Merging #9015 into stable13 will increase coverage by <.01%.
The diff coverage is 83.33%.

@@              Coverage Diff               @@
##             stable13    #9015      +/-   ##
==============================================
+ Coverage       51.33%   51.34%   +<.01%     
- Complexity      25027    25029       +2     
==============================================
  Files            1609     1609              
  Lines           95298    95305       +7     
  Branches         1376     1376              
==============================================
+ Hits            48922    48931       +9     
+ Misses          46376    46374       -2
Impacted Files Coverage Δ Complexity Δ
lib/private/Template/SCSSCacher.php 72.41% <83.33%> (+0.67%) 38 <2> (+2) ⬆️
apps/files_trashbin/lib/Trashbin.php 72.53% <0%> (+0.24%) 136% <0%> (ø) ⬇️
lib/private/Files/Cache/Propagator.php 96.2% <0%> (+1.26%) 16% <0%> (ø) ⬇️
apps/files_trashbin/lib/Expiration.php 91.93% <0%> (+1.61%) 29% <0%> (ø) ⬇️
@kyrofa

kyrofa approved these changes Mar 28, 2018

This does not fix the issue I was hoping it would, but it doesn't regress behavior and is a positive change. +1 from me, thank you!

@MorrisJobke MorrisJobke merged commit 7bb8ce0 into stable13 Apr 3, 2018

3 checks passed

codecov/patch 83.33% of diff hit (target 51.33%)
Details
codecov/project 51.34% (+<.01%) compared to f2e69bd
Details
continuous-integration/drone/pr the build was successful
Details

@MorrisJobke MorrisJobke deleted the backport-apps-versions branch Apr 3, 2018

@MorrisJobke MorrisJobke referenced this pull request Apr 18, 2018

Merged

13.0.2 RC 1 #9228

8 of 11 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment