New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable13] Do not treat is-encrypted as custom property #9071

Merged
merged 1 commit into from Apr 5, 2018

Conversation

Projects
None yet
3 participants
@rullzer
Member

rullzer commented Apr 4, 2018

Backport of #9006

Do not treat is-encrypted as customer property
fixes #8977

Else for all files in a folder we would launch off more queries.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@MorrisJobke

🐘

@codecov

This comment has been minimized.

codecov bot commented Apr 4, 2018

Codecov Report

Merging #9071 into stable13 will increase coverage by <.01%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             stable13    #9071      +/-   ##
==============================================
+ Coverage       51.33%   51.34%   +<.01%     
  Complexity      25029    25029              
==============================================
  Files            1609     1609              
  Lines           95305    95305              
  Branches         1376     1376              
==============================================
+ Hits            48924    48930       +6     
+ Misses          46381    46375       -6
Impacted Files Coverage Δ Complexity Δ
...av/lib/Connector/Sabre/CustomPropertiesBackend.php 78.67% <ø> (ø) 29 <0> (ø) ⬇️
apps/files_trashbin/lib/Trashbin.php 72.53% <0%> (+0.24%) 136% <0%> (ø) ⬇️
core/js/js.js 66.29% <0%> (+0.55%) 0% <0%> (ø) ⬇️

@rullzer rullzer requested a review from ChristophWurst Apr 4, 2018

@ChristophWurst

This comment has been minimized.

Member

ChristophWurst commented Apr 5, 2018

1 approving review by reviewers with write access

FYI this should be set to 2 required reviewers in the GitHub branch settings 😉

@rullzer rullzer merged commit 652d041 into stable13 Apr 5, 2018

3 checks passed

codecov/patch Coverage not affected when comparing e95184e...df09b65
Details
codecov/project 51.34% (+<.01%) compared to e95184e
Details
continuous-integration/drone/pr the build was successful
Details

@rullzer rullzer deleted the backport/9006/ignore_encrypted_custom_properties-13 branch Apr 5, 2018

@MorrisJobke MorrisJobke referenced this pull request Apr 18, 2018

Merged

13.0.2 RC 1 #9228

8 of 11 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment