New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable13] Fix proper permissions for multiple file access #9072

Merged
merged 2 commits into from Apr 4, 2018

Conversation

Projects
None yet
3 participants
@rullzer
Member

rullzer commented Apr 4, 2018

Backport of #8891

rullzer added some commits Mar 19, 2018

Fix proper permissions for multiple file access
Fixes #8890

In case you have access to a file via multiple ways, for example:
1. the file is shared with you with permission read only
2. the folder containing the file is shared with your read/write

Requesting the getById function on the userFolder would give back two
entries but both with the same permissions. Depending on the node you
picked this is not right.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Fix test
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

@rullzer rullzer added this to the Nextcloud 13.0.2 milestone Apr 4, 2018

@codecov

This comment has been minimized.

codecov bot commented Apr 4, 2018

Codecov Report

Merging #9072 into stable13 will not change coverage.
The diff coverage is 80%.

@@             Coverage Diff             @@
##             stable13    #9072   +/-   ##
===========================================
  Coverage       51.33%   51.33%           
  Complexity      25029    25029           
===========================================
  Files            1609     1609           
  Lines           95305    95305           
  Branches         1376     1376           
===========================================
  Hits            48924    48924           
  Misses          46381    46381
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Node/Folder.php 88.78% <80%> (ø) 50 <0> (ø) ⬇️
@MorrisJobke

🐘

@MorrisJobke MorrisJobke merged commit ba29fd1 into stable13 Apr 4, 2018

3 checks passed

codecov/patch 80% of diff hit (target 51.33%)
Details
codecov/project 51.33% (+0%) compared to e95184e
Details
continuous-integration/drone/pr the build was successful
Details

@MorrisJobke MorrisJobke deleted the backport/8891/fix_8890-13 branch Apr 4, 2018

@MorrisJobke MorrisJobke referenced this pull request Apr 18, 2018

Merged

13.0.2 RC 1 #9228

8 of 11 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment