New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable9] Fix "Undefined index" when the values do not exist #933

Merged
merged 1 commit into from Aug 18, 2016
Jump to file or symbol
Failed to load files and symbols.
+2 −2
Diff settings

Always

Just for now

Fix "Undefined index" when the values do not exist

  • Loading branch information...
nickvergessen committed Aug 18, 2016
commit f7092c981f7b5498adb474fee73c594d772d98a8
@@ -80,7 +80,7 @@ public function analyse($appId) {
$info = $this->infoParser->parse($appPath . '/appinfo/info.xml');
if (isset($info['dependencies']['owncloud']['@attributes']['min-version']) && ($info['requiremin'] || $info['require'])) {
if (isset($info['dependencies']['owncloud']['@attributes']['min-version']) && (isset($info['requiremin']) || isset($info['require']))) {
$this->emit('InfoChecker', 'duplicateRequirement', ['min']);
$errors[] = [
'type' => 'duplicateRequirement',
@@ -90,7 +90,7 @@ public function analyse($appId) {
$this->emit('InfoChecker', 'missingRequirement', ['min']);
}
if (isset($info['dependencies']['owncloud']['@attributes']['max-version']) && $info['requiremax']) {
if (isset($info['dependencies']['owncloud']['@attributes']['max-version']) && isset($info['requiremax'])) {
$this->emit('InfoChecker', 'duplicateRequirement', ['max']);
$errors[] = [
'type' => 'duplicateRequirement',
ProTip! Use n and p to navigate between commits in a pull request.