New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable13] Fix ellipsis in filename column #9344

Merged
merged 2 commits into from May 1, 2018

Conversation

Projects
None yet
5 participants
@juliushaertl
Member

juliushaertl commented Apr 30, 2018

backport of #9248

@nextcloud/designers

juliushaertl added some commits Apr 19, 2018

Use flex based layout inside the filename table cell
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Add min-width to trick the table width calculation in safari
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@johnyb0y

This comment has been minimized.

johnyb0y commented Apr 30, 2018

Thanks!

@MorrisJobke

This comment has been minimized.

Member

MorrisJobke commented Apr 30, 2018

JS failure seems unrelated, because this is an SCSS only change.

@skjnldsv

This comment has been minimized.

Member

skjnldsv commented Apr 30, 2018

@MorrisJobke restarted to be sure :)

@MorrisJobke

Tested and works 👍

@skjnldsv

This comment has been minimized.

Member

skjnldsv commented Apr 30, 2018

Same error, it might be good to look at it:

PhantomJS 2.1.1 (Linux 0.0.0) DeleteHandler tests deletes first entry and reshows notification on second delete FAILED
	TypeError: undefined is not a function (evaluating 'showNotificationSpy.reset()') in settings/tests/js/users/deleteHandlerSpec.js (line 82)
	settings/tests/js/users/deleteHandlerSpec.js:82:28

@juliushaertl

This comment has been minimized.

Member

juliushaertl commented Apr 30, 2018

@skjnldsv It seems that it is also failing on master/stable13 since the test dependency sinon has removed a deprecated method in their new release 3 days ago.

Fix is in #9348

@rullzer

rullzer approved these changes May 1, 2018

@rullzer rullzer merged commit 6976241 into stable13 May 1, 2018

0 of 2 checks passed

continuous-integration/drone/pr the build failed
Details
continuous-integration/drone/push the build failed
Details

@rullzer rullzer deleted the stable13-9248 branch May 1, 2018

@MorrisJobke MorrisJobke referenced this pull request May 31, 2018

Merged

13.0.3 RC 1 #9700

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment