New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable13] Replace deprecated sinon reset() call with resetHistory() #9358

Merged
merged 1 commit into from May 2, 2018

Conversation

Projects
None yet
3 participants
@juliushaertl
Member

juliushaertl commented May 2, 2018

backport of #9348 to fix the failing jsunit tests

Replace deprecated sinon reset() call with resetHistory()
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@rullzer

rullzer approved these changes May 2, 2018

@codecov

This comment has been minimized.

codecov bot commented May 2, 2018

Codecov Report

Merging #9358 into stable13 will increase coverage by 0.51%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             stable13    #9358      +/-   ##
==============================================
+ Coverage       50.84%   51.36%   +0.51%     
  Complexity      25047    25047              
==============================================
  Files            1544     1609      +65     
  Lines           87532    95333    +7801     
  Branches            0     1376    +1376     
==============================================
+ Hits            44508    48966    +4458     
- Misses          43024    46367    +3343
Impacted Files Coverage Δ Complexity Δ
apps/comments/js/commentstabview.js 84.25% <0%> (ø) 0% <0%> (?)
core/js/sharedialogview.js 75.43% <0%> (ø) 0% <0%> (?)
apps/files_external/js/app.js 15.9% <0%> (ø) 0% <0%> (?)
core/js/systemtags/systemtags.js 100% <0%> (ø) 0% <0%> (?)
settings/js/apps.js 24.39% <0%> (ø) 0% <0%> (?)
core/js/systemtags/systemtagmodel.js 100% <0%> (ø) 0% <0%> (?)
core/js/systemtags/systemtagsinputfield.js 82.79% <0%> (ø) 0% <0%> (?)
core/js/setupchecks.js 96.29% <0%> (ø) 0% <0%> (?)
apps/systemtags/js/app.js 15.55% <0%> (ø) 0% <0%> (?)
apps/comments/js/commentcollection.js 90.9% <0%> (ø) 0% <0%> (?)
... and 55 more

@rullzer rullzer merged commit 9763e7d into stable13 May 2, 2018

4 checks passed

codecov/patch Coverage not affected when comparing 6976241...f3b3b5f
Details
codecov/project 51.36% (+0.51%) compared to 6976241
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/drone/push the build was successful
Details

@rullzer rullzer deleted the stable13-9348 branch May 2, 2018

@MorrisJobke MorrisJobke referenced this pull request May 31, 2018

Merged

13.0.3 RC 1 #9700

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment