New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable12] Replace deprecated sinon reset() call with resetHistory() #9359

Merged
merged 1 commit into from May 2, 2018

Conversation

Projects
None yet
4 participants
@juliushaertl
Member

juliushaertl commented May 2, 2018

backport of #9348 to fix the failing jsunit tests

Replace deprecated sinon reset() call with resetHistory()
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@rullzer

rullzer approved these changes May 2, 2018

@codecov

This comment has been minimized.

codecov bot commented May 2, 2018

Codecov Report

Merging #9359 into stable12 will increase coverage by 0.24%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             stable12    #9359      +/-   ##
==============================================
+ Coverage       53.66%   53.91%   +0.24%     
  Complexity      22785    22785              
==============================================
  Files            1325     1387      +62     
  Lines           79765    87300    +7535     
  Branches            0     1331    +1331     
==============================================
+ Hits            42803    47064    +4261     
- Misses          36962    40236    +3274
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Cache/Propagator.php 94.93% <0%> (-1.27%) 16% <0%> (ø)
core/js/oc-backbone-webdav.js 85.41% <0%> (ø) 0% <0%> (?)
apps/files_sharing/js/sharetabview.js 83.33% <0%> (ø) 0% <0%> (?)
core/js/contactsmenu.js 90% <0%> (ø) 0% <0%> (?)
apps/files_external/js/mountsfilelist.js 87.27% <0%> (ø) 0% <0%> (?)
core/js/config.js 6.66% <0%> (ø) 0% <0%> (?)
apps/files_sharing/js/public.js 47.91% <0%> (ø) 0% <0%> (?)
apps/files_external/js/app.js 15.9% <0%> (ø) 0% <0%> (?)
core/js/public/appconfig.js 4.76% <0%> (ø) 0% <0%> (?)
core/js/share.js 40.98% <0%> (ø) 0% <0%> (?)
... and 53 more

@skjnldsv skjnldsv merged commit 056f62d into stable12 May 2, 2018

4 checks passed

codecov/patch Coverage not affected when comparing 4234e0e...02b0a32
Details
codecov/project 53.91% (+0.24%) compared to 4234e0e
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/drone/push the build was successful
Details

@skjnldsv skjnldsv deleted the stable12-9348 branch May 2, 2018

@MorrisJobke MorrisJobke referenced this pull request May 31, 2018

Merged

12.0.8 RC 1 #9702

2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment