New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable13] Allow IPv6 database host #9432

Merged
merged 5 commits into from May 14, 2018

Conversation

Projects
None yet
3 participants
@nickvergessen
Member

nickvergessen commented May 9, 2018

Backport #9225

nickvergessen and others added some commits Apr 18, 2018

Allow IPv6 database hosts
Signed-off-by: Joas Schilling <coding@schilljs.com>
Move regex to a function and add tests
Signed-off-by: Joas Schilling <coding@schilljs.com>
Add tests for domains
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Add tests for special domain name
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
* @param string $host
* @return array
*/
protected function splitHostFromPortAndSocket($host): array {

This comment has been minimized.

@MorrisJobke

MorrisJobke May 9, 2018

Member

13 is on PHP 5.6 🙈

This comment has been minimized.

@nickvergessen

nickvergessen May 9, 2018

Member

I knew there was a trap

php 5.6 compatibility
Signed-off-by: Joas Schilling <coding@schilljs.com>
@codecov

This comment has been minimized.

codecov bot commented May 9, 2018

Codecov Report

Merging #9432 into stable13 will increase coverage by <.01%.
The diff coverage is 90%.

@@              Coverage Diff               @@
##             stable13    #9432      +/-   ##
==============================================
+ Coverage       51.36%   51.36%   +<.01%     
- Complexity      25051    25052       +1     
==============================================
  Files            1609     1609              
  Lines           95342    95346       +4     
  Branches         1376     1376              
==============================================
+ Hits            48973    48976       +3     
- Misses          46369    46370       +1
Impacted Files Coverage Δ Complexity Δ
lib/private/DB/ConnectionFactory.php 67.07% <90%> (+8.09%) 24 <3> (+1) ⬆️
apps/files_trashbin/lib/Expiration.php 90.32% <0%> (-1.62%) 29% <0%> (ø)
core/js/js.js 65.74% <0%> (-0.56%) 0% <0%> (ø)
@rullzer

rullzer approved these changes May 9, 2018

@MorrisJobke

🐘

@MorrisJobke MorrisJobke merged commit 003cc5a into stable13 May 14, 2018

3 checks passed

codecov/patch 90% of diff hit (target 51.36%)
Details
codecov/project 51.36% (+<.01%) compared to 44255fa
Details
continuous-integration/drone/pr the build was successful
Details

@MorrisJobke MorrisJobke deleted the backport/9225/ipv6-database-host branch May 14, 2018

@MorrisJobke MorrisJobke referenced this pull request May 31, 2018

Merged

13.0.3 RC 1 #9700

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment