New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable13] Get correct version of an app #9436

Merged
merged 1 commit into from May 14, 2018

Conversation

Projects
None yet
3 participants
@rullzer
Member

rullzer commented May 9, 2018

Backport of #9373

Get correct version of an app
Related to #8929

We should get the version of the app. Not of the appfolder. Else there
is no way to properly compare the versions.

Now note that installing in 1 go will still fail. But at least on the
next page load the new version will be properly detected.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

@rullzer rullzer added this to the Nextcloud 13.0.3 milestone May 9, 2018

@rullzer rullzer requested review from nickvergessen and MorrisJobke May 9, 2018

@codecov

This comment has been minimized.

codecov bot commented May 9, 2018

Codecov Report

Merging #9436 into stable13 will not change coverage.
The diff coverage is 0%.

@@             Coverage Diff             @@
##             stable13    #9436   +/-   ##
===========================================
  Coverage       51.36%   51.36%           
  Complexity      25051    25051           
===========================================
  Files            1609     1609           
  Lines           95342    95342           
  Branches         1376     1376           
===========================================
  Hits            48973    48973           
  Misses          46369    46369
Impacted Files Coverage Δ Complexity Δ
lib/private/legacy/app.php 57.44% <0%> (ø) 222 <0> (ø) ⬇️

@MorrisJobke MorrisJobke merged commit 1aa149a into stable13 May 14, 2018

2 of 3 checks passed

codecov/patch 0% of diff hit (target 51.36%)
Details
codecov/project 51.36% remains the same compared to 44255fa
Details
continuous-integration/drone/pr the build was successful
Details

@MorrisJobke MorrisJobke deleted the backport/9373/stable13 branch May 14, 2018

@MorrisJobke MorrisJobke referenced this pull request May 31, 2018

Merged

13.0.3 RC 1 #9700

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment