New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable13] allow to specify a link to a legal notice #9516

Merged
merged 1 commit into from May 22, 2018

Conversation

Projects
None yet
3 participants
@blizzz
Member

blizzz commented May 18, 2018

Backport of #9437

Backport of #9437
allow to specify a link to a legal notice

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

fix tests

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

fix undo for url-typed inputs

and minor adjustments

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

Use link not address in labels for URLs

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

this file does not belong here

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@codecov

This comment has been minimized.

codecov bot commented May 18, 2018

Codecov Report

Merging #9516 into stable13 will decrease coverage by <.01%.
The diff coverage is 50%.

@@              Coverage Diff               @@
##             stable13    #9516      +/-   ##
==============================================
- Coverage       51.38%   51.38%   -0.01%     
- Complexity      25052    25057       +5     
==============================================
  Files            1609     1609              
  Lines           95350    95373      +23     
  Branches         1376     1376              
==============================================
+ Hits            48999    49010      +11     
- Misses          46351    46363      +12
Impacted Files Coverage Δ Complexity Δ
apps/theming/templates/settings-admin.php 0% <0%> (ø) 0 <0> (ø) ⬇️
apps/theming/lib/Settings/Admin.php 86.48% <100%> (+0.37%) 5 <0> (ø) ⬇️
apps/theming/lib/ThemingDefaults.php 92.25% <100%> (+0.46%) 49 <1> (+3) ⬆️
apps/theming/lib/Controller/ThemingController.php 73.16% <20%> (-2.03%) 45 <0> (+2)
@rullzer

Fine by me!

@MorrisJobke

Tested and works 👍

@MorrisJobke MorrisJobke merged commit 5744827 into stable13 May 22, 2018

1 of 3 checks passed

codecov/patch 50% of diff hit (target 51.38%)
Details
codecov/project 51.38% (-0.01%) compared to c101ad3
Details
continuous-integration/drone/pr the build was successful
Details

@MorrisJobke MorrisJobke deleted the backport/9437/stable13 branch May 22, 2018

@MorrisJobke MorrisJobke referenced this pull request May 31, 2018

Merged

13.0.3 RC 1 #9700

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment