New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable13] Fix translation bug on lost password page #9548

Merged
merged 1 commit into from May 22, 2018

Conversation

Projects
None yet
3 participants
@remyj38
Contributor

remyj38 commented May 22, 2018

During resetting user's password, the controller return the untranslated message (from basic exception) instead of the hint message (translated).

Fix nextcloud/password_policy#26

Signed-off-by: Rémy Jacquin remy@remyj.fr

Fix translation bug on lost password page
Fix nextcloud/password_policy#26

Signed-off-by: Rémy Jacquin <remy@remyj.fr>
@ChristophWurst

Thanks! 🤖

@codecov

This comment has been minimized.

codecov bot commented May 22, 2018

Codecov Report

Merging #9548 into stable13 will decrease coverage by <.01%.
The diff coverage is 50%.

@@              Coverage Diff               @@
##             stable13    #9548      +/-   ##
==============================================
- Coverage       51.38%   51.38%   -0.01%     
- Complexity      25057    25058       +1     
==============================================
  Files            1609     1609              
  Lines           95373    95375       +2     
  Branches         1376     1376              
==============================================
- Hits            49010    49006       -4     
- Misses          46363    46369       +6
Impacted Files Coverage Δ Complexity Δ
core/Controller/LostController.php 79.35% <50%> (-0.39%) 33 <0> (+1)
core/js/js.js 65.81% <0%> (-0.56%) 0% <0%> (ø)

@MorrisJobke MorrisJobke merged commit 04ff701 into nextcloud:stable13 May 22, 2018

1 of 3 checks passed

codecov/patch 50% of diff hit (target 51.38%)
Details
codecov/project 51.38% (-0.01%) compared to 5744827
Details
continuous-integration/drone/pr the build was successful
Details

@MorrisJobke MorrisJobke referenced this pull request May 31, 2018

Merged

13.0.3 RC 1 #9700

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment