New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable13] Fix settings menu #9590

Merged
merged 1 commit into from May 24, 2018

Conversation

Projects
None yet
5 participants
@juliushaertl
Member

juliushaertl commented May 24, 2018

This fixes #9514 which was introduced in fc280b2 where the settings menu was moved to a nav element and therefore the css rules scope was to wide.

Doesn't happen on master to me.

Before:
image

After:
image

@nextcloud/designers

Fix scope of nav css rule
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@skjnldsv

This comment has been minimized.

Member

skjnldsv commented May 24, 2018

Nice catch! Doesn't happen on master to me as well :/

@juliushaertl juliushaertl added the design label May 24, 2018

@blizzz

blizzz approved these changes May 24, 2018

works!

@skjnldsv

How did this happened..... 🙈

@skjnldsv skjnldsv added 4. to release and removed 3. to review labels May 24, 2018

@skjnldsv

This comment has been minimized.

Member

skjnldsv commented May 24, 2018

I don't get it, My current setup was a few commits late and I did not have this issue.

@juliushaertl

This comment has been minimized.

Member

juliushaertl commented May 24, 2018

@skjnldsv I also needed a hard refresh to reload the css to make it occur. 😉

@skjnldsv

This comment has been minimized.

Member

skjnldsv commented May 24, 2018

@skjnldsv I also needed a hard refresh to reload the css to make it occur. wink

This was still working on a794806 🤔

@skjnldsv

This comment has been minimized.

Member

skjnldsv commented May 24, 2018

Found the commits responsible:
ea834da...223f034
Working before that and not after :)

@MorrisJobke MorrisJobke merged commit e2133ae into stable13 May 24, 2018

1 check was pending

continuous-integration/drone/pr this build is pending
Details

@MorrisJobke MorrisJobke deleted the bug/9514/fix-settings-menu branch May 24, 2018

@MorrisJobke MorrisJobke referenced this pull request May 24, 2018

Closed

main menu bar #9514

@jancborchardt

This comment has been minimized.

Member

jancborchardt commented May 25, 2018

@juliushaertl woah, it was introduced in 2012?

@skjnldsv

This comment has been minimized.

Member

skjnldsv commented May 25, 2018

@jancborchardt no, julius linked the wrong commit.
This comes from your latest aria implementation :)
0dc52bf#diff-8BE54A6D336A8809304EF06B951698A9R131

@juliushaertl

This comment has been minimized.

Member

juliushaertl commented May 26, 2018

Oh sorry about that ... Somehow got the link wrong. 🙈 @skjnldsv posted the right link.

@jancborchardt

This comment has been minimized.

Member

jancborchardt commented May 28, 2018

Riight, that’s what I thought :D

@MorrisJobke MorrisJobke referenced this pull request May 31, 2018

Merged

13.0.3 RC 1 #9700

@skjnldsv skjnldsv referenced this pull request Jun 4, 2018

Merged

[stable13] Fix header nav #9727

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment