New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13] Handle exception while itterating trough smb file listing #9608

Merged
merged 1 commit into from May 29, 2018

Conversation

Projects
None yet
3 participants
@icewind1991
Member

icewind1991 commented May 25, 2018

Backport of #8285

When using the php-smbclient backend getting the metadata from a file entry can trigger a request and thus an exception.

Make SMB module more fault-tolerant
Ignore unavailable files when fetching the share's mtime
or reading directory listings. This can happen on servers using a
distributed file system (DFS) with unavailable destinations, for example
when the remote server is offline.

Signed-off-by: Roland Tapken <roland@bitarbeiter.net>

@icewind1991 icewind1991 added this to the Nextcloud 13.0.3 milestone May 25, 2018

@icewind1991 icewind1991 requested review from rullzer and MorrisJobke May 25, 2018

@rullzer

🐘

@MorrisJobke MorrisJobke merged commit 9f793f9 into stable13 May 29, 2018

1 check failed

continuous-integration/drone/pr the build failed
Details

@MorrisJobke MorrisJobke deleted the smb-exceptions-on-listing branch May 29, 2018

@MorrisJobke MorrisJobke referenced this pull request May 31, 2018

Merged

13.0.3 RC 1 #9700

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment