New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable13] Emit event when running ./occ db:add-missing-indices #9620

Merged
merged 1 commit into from May 29, 2018

Conversation

Projects
None yet
4 participants
@rullzer
Member

rullzer commented May 26, 2018

Backport of #9576

@@ -1,4 +1,5 @@
<?php
declare(strict_types=1);

This comment has been minimized.

@ChristophWurst

ChristophWurst May 28, 2018

Member

Shouldn't stable13 be compatible with php5.6? Does this line work for that?

This comment has been minimized.

@rullzer

rullzer May 28, 2018

Member

yes you are right... Let me fix that

Emit event when running ./occ db:add-missing-indices
This allows apps to listen to this event in order to also update
indecies there.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@codecov

This comment has been minimized.

codecov bot commented May 28, 2018

Codecov Report

Merging #9620 into stable13 will decrease coverage by <.01%.
The diff coverage is 0%.

@@              Coverage Diff               @@
##             stable13    #9620      +/-   ##
==============================================
- Coverage       50.87%   50.87%   -0.01%     
  Complexity      25097    25097              
==============================================
  Files            1547     1547              
  Lines           87718    87723       +5     
==============================================
  Hits            44628    44628              
- Misses          43090    43095       +5
Impacted Files Coverage Δ Complexity Δ
core/register_command.php 0% <0%> (ø) 0 <0> (ø) ⬇️
core/Command/Db/AddMissingIndices.php 0% <0%> (ø) 7 <1> (ø) ⬇️
index.php 0% <0%> (ø) 0% <0%> (ø) ⬇️
@ChristophWurst

LGTM

@MorrisJobke MorrisJobke merged commit b03752b into stable13 May 29, 2018

1 check failed

continuous-integration/drone/pr the build failed
Details

@MorrisJobke MorrisJobke deleted the backport/9576/stable13 branch May 29, 2018

@MorrisJobke MorrisJobke referenced this pull request May 31, 2018

Merged

13.0.3 RC 1 #9700

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment