New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable13] Limit Sinon version to 5.0.7 at most #9629

Merged
merged 1 commit into from May 28, 2018

Conversation

Projects
None yet
4 participants
@MorrisJobke
Member

MorrisJobke commented May 28, 2018

Backport of #9627

Limit Sinon version to 5.0.7 at most
When using fake servers with Sinon.JS, the JavaScript test framework,
the XHR objects are also fake. In Sinon 5.0.8 the "setRequestHeader" of
XMLHttpRequest was modified to normalize the header values (as requested
by the spec), but since then only string values are accepted; null or
integer values can no longer be passed to "setRequestHeader", as it
expects the "replace" function to be available in the object. However,
in the tests null and integer values are passed to "setRequestHeader",
which causes them to fail.

Both Firefox and Chromium accept passing non-string values to their
"setRequestHeader" implementation, and it is done, for example, in
davclient.js; it is not clear yet whether Sinon got too restrictive or
the code calling "setRequestHeader" was too loose. Given that
davclient.js is an external dependency, as a temporary measure Sinon
version is forced to be 5.0.7 at most until either Sinon or davclient.js
are updated.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

@MorrisJobke MorrisJobke added this to the Nextcloud 13.0.3 milestone May 28, 2018

@MorrisJobke MorrisJobke requested review from rullzer, skjnldsv and danxuliu May 28, 2018

@MorrisJobke

This comment has been minimized.

Member

MorrisJobke commented May 28, 2018

👍 from my side as well

@danxuliu

Let's wait for CI before merging to be sure, but it should pass ;-)

@codecov

This comment has been minimized.

codecov bot commented May 28, 2018

Codecov Report

Merging #9629 into stable13 will increase coverage by 0.53%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             stable13   #9629      +/-   ##
=============================================
+ Coverage       50.87%   51.4%   +0.53%     
  Complexity      25097   25097              
=============================================
  Files            1547    1612      +65     
  Lines           87719   95520    +7801     
  Branches            0    1376    +1376     
=============================================
+ Hits            44628   49104    +4476     
- Misses          43091   46416    +3325
Impacted Files Coverage Δ Complexity Δ
apps/comments/js/app.js 100% <0%> (ø) 0% <0%> (?)
core/js/octemplate.js 11.11% <0%> (ø) 0% <0%> (?)
apps/files_versions/js/versionmodel.js 96.42% <0%> (ø) 0% <0%> (?)
core/js/systemtags/systemtagsmappingcollection.js 68.42% <0%> (ø) 0% <0%> (?)
apps/files_sharing/js/app.js 77.1% <0%> (ø) 0% <0%> (?)
core/js/multiselect.js 2.33% <0%> (ø) 0% <0%> (?)
apps/systemtags/js/systemtagsinfoview.js 98.27% <0%> (ø) 0% <0%> (?)
core/js/sharesocialmanager.js 87.5% <0%> (ø) 0% <0%> (?)
apps/systemtags/js/filesplugin.js 25% <0%> (ø) 0% <0%> (?)
core/js/public/appconfig.js 4.76% <0%> (ø) 0% <0%> (?)
... and 55 more

@rullzer rullzer merged commit c07f23c into stable13 May 28, 2018

3 checks passed

codecov/patch Coverage not affected when comparing 5536d17...fe93f09
Details
codecov/project 51.4% (+0.53%) compared to 5536d17
Details
continuous-integration/drone/pr the build was successful
Details

@rullzer rullzer deleted the backport/9627/stable13 branch May 28, 2018

@MorrisJobke MorrisJobke referenced this pull request May 31, 2018

Merged

13.0.3 RC 1 #9700

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment