New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable12] Make sure the log doesn't try to read from PUT if it can't #9695

Merged
merged 1 commit into from Jun 1, 2018

Conversation

@rullzer
Member

rullzer commented May 30, 2018

Backport of #9692

Make sure the log doesn't try to read from PUT if it can't
If a PUT request comes in that is not JSON or from encoded. Then we can
only read it (exactly) once. If that is the case we must assume no
shared secret is set.

If we don't then we either are the first to read it, thus causing the
real read of the data to fail.

Or we are later and then it throws an exception (also failing the
request).

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

@rullzer rullzer added this to the Nextcloud 12.0.8 milestone May 30, 2018

@rullzer rullzer changed the title from Make sure the log doesn't try to read from PUT if it can't to [stable12] Make sure the log doesn't try to read from PUT if it can't May 30, 2018

@MorrisJobke MorrisJobke referenced this pull request May 31, 2018

Merged

12.0.8 RC 1 #9702

2 of 2 tasks complete

@MorrisJobke MorrisJobke requested a review from skjnldsv Jun 1, 2018

@MorrisJobke MorrisJobke merged commit a55241c into stable12 Jun 1, 2018

1 check failed

continuous-integration/drone/pr the build failed
Details

@MorrisJobke MorrisJobke deleted the backport/9692/stable12 branch Jun 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment