New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable13] Make the token expiration also work for autocasting 0 #9803

Merged
merged 1 commit into from Jun 11, 2018

Conversation

Projects
None yet
3 participants
@rullzer
Member

rullzer commented Jun 8, 2018

Backport of #9802

Make the token expiration also work for autocasting 0
Some bad databases don't respect the default null apprently.
Now even if they cast it to 0 it should work just fine.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

@rullzer rullzer added this to the Nextcloud 13.0.4 milestone Jun 8, 2018

@rullzer rullzer requested review from MorrisJobke and blizzz Jun 8, 2018

@codecov

This comment has been minimized.

codecov bot commented Jun 8, 2018

Codecov Report

Merging #9803 into stable13 will increase coverage by <.01%.
The diff coverage is 100%.

@@              Coverage Diff               @@
##             stable13    #9803      +/-   ##
==============================================
+ Coverage       51.43%   51.44%   +<.01%     
  Complexity      25135    25135              
==============================================
  Files            1613     1613              
  Lines           95626    95626              
  Branches         1376     1376              
==============================================
+ Hits            49190    49191       +1     
+ Misses          46436    46435       -1
Impacted Files Coverage Δ Complexity Δ
...vate/Authentication/Token/DefaultTokenProvider.php 98.03% <100%> (ø) 32 <0> (ø) ⬇️
apps/files_trashbin/lib/Expiration.php 91.93% <0%> (+1.61%) 29% <0%> (ø) ⬇️

@skjnldsv skjnldsv merged commit bf7620d into stable13 Jun 11, 2018

3 checks passed

codecov/patch 100% of diff hit (target 51.43%)
Details
codecov/project 51.44% (+<.01%) compared to c55e842
Details
continuous-integration/drone/pr the build was successful
Details

@skjnldsv skjnldsv deleted the backport/9802/stable13 branch Jun 11, 2018

@MorrisJobke MorrisJobke referenced this pull request Jun 11, 2018

Merged

13.0.4 #9821

1 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment