New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reading PATH_INFO from server variable #984

Merged
merged 1 commit into from Aug 20, 2016

Conversation

Projects
None yet
4 participants
@LukasReschke
Member

LukasReschke commented Aug 19, 2016

Having two code paths for this is unreliable and can lead to bugs. Also, in some cases Apache isn't setting the PATH_INFO variable when mod_rewrite is used.

Fixes #983

Remove reading PATH_INFO from server variable
Having two code paths for this is unreliable and can lead to bugs. Also, in some cases Apache isn't setting the PATH_INFO variable when mod_rewrite is used.

Fixes #983
@nickvergessen

This comment has been minimized.

Show comment
Hide comment
@nickvergessen
Member

nickvergessen commented Aug 19, 2016

👍

@rullzer

This comment has been minimized.

Show comment
Hide comment
@rullzer

rullzer Aug 20, 2016

Member

LGTM

Member

rullzer commented Aug 20, 2016

LGTM

@rullzer rullzer merged commit 8fbec6a into master Aug 20, 2016

4 checks passed

Scrutinizer No new issues
Details
approvals/lgtm this commit looks good
continuous-integration/drone the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rullzer rullzer deleted the dont-read-server-variable branch Aug 20, 2016

@nickvergessen

This comment has been minimized.

Show comment
Hide comment
@nickvergessen

nickvergessen Aug 22, 2016

Member

Backport to 10 please @LukasReschke

Member

nickvergessen commented Aug 22, 2016

Backport to 10 please @LukasReschke

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment