Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable12] Make the DELETION of groups match greedy on the groupID #9842

Merged
merged 1 commit into from Jun 12, 2018

Conversation

@rullzer
Copy link
Member

commented Jun 12, 2018

Backport of #9814

Make the DELETION of groups match greedy on the groupID
fixes #6032

Now since the match is greedy it will also eat the /

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

@rullzer rullzer added this to the Nextcloud 12.0.10 milestone Jun 12, 2018

@rullzer rullzer requested review from MorrisJobke and skjnldsv Jun 12, 2018

@codecov

This comment has been minimized.

Copy link

commented Jun 12, 2018

Codecov Report

Merging #9842 into stable12 will increase coverage by <.01%.
The diff coverage is 0%.

@@              Coverage Diff               @@
##             stable12    #9842      +/-   ##
==============================================
+ Coverage       53.93%   53.93%   +<.01%     
  Complexity      22824    22824              
==============================================
  Files            1389     1389              
  Lines           87429    87429              
  Branches         1331     1331              
==============================================
+ Hits            47151    47152       +1     
+ Misses          40278    40277       -1
Impacted Files Coverage Δ Complexity Δ
apps/provisioning_api/appinfo/routes.php 0% <0%> (ø) 0 <0> (ø) ⬇️
lib/private/Files/Cache/Propagator.php 96.2% <0%> (+1.26%) 16% <0%> (ø) ⬇️
@MorrisJobke
Copy link
Member

left a comment

Code makes sense 👍

@MorrisJobke MorrisJobke merged commit 00db9ec into stable12 Jun 12, 2018

2 of 3 checks passed

codecov/patch 0% of diff hit (target 53.93%)
Details
codecov/project 53.93% (+<.01%) compared to 73ba8d4
Details
continuous-integration/drone/pr the build was successful
Details

@MorrisJobke MorrisJobke deleted the backport/9814/stable12 branch Jun 12, 2018

@MorrisJobke MorrisJobke referenced this pull request Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.