New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make table name configurable for db user backend #9868
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9868 +/- ##
============================================
- Coverage 52.07% 52.07% -0.01%
Complexity 25901 25901
============================================
Files 1642 1642
Lines 95884 95885 +1
Branches 1318 1318
============================================
Hits 49929 49929
- Misses 45955 45956 +1
|
Would it not be 'safer' to just have the guest app have its own tables? And implement a real backend? |
I guess he wants to save some code, but then this is not in the public namespace either |
I would really prefer to do it properly in its own backend. That way if we want to change something in either the app backend or the db user backend we can do so without worrying of breaking the other. |
Creating a separate backend would be an almost complete copy paste from this backend |
I created a separate PR with all changes from this one except the configurable table name |
Signed-off-by: Robin Appelman <robin@icewind.nl>
b80e21e
to
3392302
Compare
Rebased after #9881 was merged ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok fair enough. Lets do it like this. if it turns out it diverges to much we can later always move this over to the app.
So 👍 for now :D
The main use case for this is to make it easy to create a separate user backend for the guest app (to prevent guests from becoming "real" users if the app gets disabled for any reason).