Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix navigation keyboard accessibility #9951

Merged
merged 1 commit into from Jun 21, 2018

Conversation

Projects
None yet
3 participants
@jancborchardt
Copy link
Member

commented Jun 21, 2018

This makes the app-navigation accessible via keyboard. As discussed @skjnldsv

You can test via simply using Tab and Shift-Tab to navigate, and Enter to choose. Please review @nextcloud/designers @nextcloud/accessibility

Fix navigation keyboard accessibility
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
@juliushaertl

This comment has been minimized.

Copy link
Member

commented Jun 21, 2018

So it is about the 3-dots menut for more apps, right? As the regular app menu icons were already keyboard browsable for me even before that.

@codecov

This comment has been minimized.

Copy link

commented Jun 21, 2018

Codecov Report

Merging #9951 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #9951   +/-   ##
=========================================
  Coverage     52.09%   52.09%           
  Complexity    25944    25944           
=========================================
  Files          1645     1645           
  Lines         95828    95828           
  Branches       1290     1290           
=========================================
  Hits          49917    49917           
  Misses        45911    45911

@skjnldsv skjnldsv merged commit 912a657 into master Jun 21, 2018

4 checks passed

Scrutinizer No new issues
Details
codecov/patch Coverage not affected when comparing a10690c...c6aff09
Details
codecov/project 52.09% remains the same compared to a10690c
Details
continuous-integration/drone/pr the build was successful
Details

@skjnldsv skjnldsv deleted the navigation-accessibility branch Jun 21, 2018

@jancborchardt

This comment has been minimized.

Copy link
Member Author

commented Jun 21, 2018

@juliushaertl no, this is about app-navigation, the element :) the left sidebar, so to say.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.